Re: [PATCH v7 0/13] MR9489: mf: Fix seeking within sample grabber.
Nikolay Sivov (@nsivov) commented about dlls/mf/tests/mf.c:
+ samples_requested = count_samples_requested(stream); + todo_wine + ok(samples_requested == 4, "Unexpected number of samples requested %d\n", samples_requested); + + /* test number of new sample requests on seek whilst paused and 3 samples provided */ + supply_samples(stream, 3); + + hr = IMFPresentationClock_Pause(clock); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + + hr = IMFPresentationClock_Start(clock, 0); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + + samples_requested = count_samples_requested(stream); + todo_wine + ok(samples_requested == 3, "Unexpected number of samples requested %d\n", samples_requested); In this sequence, how could you tell that requests are coming on Pause -> Start transition (is that what we are trying to test?)? Does it rely on a fact that we pushed fewer than requested?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9489#note_127076
participants (1)
-
Nikolay Sivov (@nsivov)