[PATCH 0/1] MR8762: win32u: Remove a log message in get_shared_window.

[Tim Clem (＠tclem)]

This message is *very* noisy and totally dominates +win (e.g. it printed 1.5 million times in a relatively short log of a Steam session). Is it useful? If so, perhaps we could log only around the error conditions?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8762

[PATCH 1/1] win32u: Remove a log message in get_shared_window.

[Tim Clem]

From: Tim Clem <tclem(a)codeweavers.com>

---
 dlls/win32u/window.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/dlls/win32u/window.c b/dlls/win32u/window.c
index 4a9e817c7e4..9b90c2d72c3 100644
--- a/dlls/win32u/window.c
+++ b/dlls/win32u/window.c
@@ -129,8 +129,6 @@ static NTSTATUS get_shared_window( HANDLE handle, struct object_lock *lock, cons
     const shared_object_t *object;
     struct user_entry entry;
 
-    TRACE( "handle %p, lock %p, window_shm %p\n", handle, lock, window_shm );
-
     if (!get_user_entry( handle, NTUSER_OBJ_WINDOW, &entry, &handle )) return STATUS_INVALID_HANDLE;
 
     if (lock->id) object = CONTAINING_RECORD( *window_shm, shared_object_t, shm.window );
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/8762

[PATCH 0/1] MR8762: win32u: Remove a log message in get_shared_window. - approved

[Rémi Bernon]

This merge request was approved by Rémi Bernon.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8762

[Rémi Bernon]

Yeah I also felt the same, didn't get to it. Thanks

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8762#note_112798

[Rémi Bernon]

The warning will need to be fixed even though I think it's a false positive (just needs an initialization).

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8762#note_112800