[PATCH v2 0/1] MR9362: opengl32: Simplify extension tokenization.

[Rémi Bernon]

This was requested in !9263 review, but ignored for some reason.

--
  v2: opengl32: Simplify extension tokenization.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9362

[PATCH v2 1/1] opengl32: Simplify extension tokenization.

[Rémi Bernon]

From: Rémi Bernon <rbernon(a)codeweavers.com>

---
 dlls/opengl32/unix_wgl.c | 33 ++++++++++++---------------------
 1 file changed, 12 insertions(+), 21 deletions(-)

diff --git a/dlls/opengl32/unix_wgl.c b/dlls/opengl32/unix_wgl.c
index 4f346b39226..4aa45786bff 100644
--- a/dlls/opengl32/unix_wgl.c
+++ b/dlls/opengl32/unix_wgl.c
@@ -1233,29 +1233,20 @@ static void make_context_current( TEB *teb, const struct opengl_funcs *funcs, HD
     }
     else
     {
-        const char *str = (const char *)funcs->p_glGetString( GL_EXTENSIONS );
-        size_t len = strlen( str );
-        const char *p;
-        char *ext;
-        if (!str) str = "";
-        if ((len = strlen( str )) && str[len - 1] == ' ') len--;
-        if (*str) size++;
-        for (p = str; p < str + len; p++) if (*p == ' ') size++;
-        if (!(extensions = malloc( size * sizeof(*extensions) + len + 1 ))) return;
-        ext = (char *)&extensions[size];
-        memcpy( ext, str, len );
-        ext[len] = 0;
-        if (*ext) extensions[count++] = ext;
-        while (*ext)
+        const char *str, *ptr;
+        char *out;
+
+        if (!(str = (const char *)funcs->p_glGetString( GL_EXTENSIONS ))) str = "";
+        for (ptr = str; *ptr; ptr++) if (ptr == str || ptr[-1] == ' ') size++;
+
+        if (!(extensions = malloc( size * sizeof(*extensions) + (ptr - str) ))) return;
+
+        for (out = (char *)&extensions[size], ptr = str; *ptr; out++, ptr++)
         {
-            if (*ext == ' ')
-            {
-                *ext = 0;
-                extensions[count++] = ext + 1;
-            }
-            ext++;
+            if (ptr == str || ptr[-1] == ' ') extensions[count++] = out;
+            *out = *ptr == ' ' ? 0 : *ptr;
         }
-        assert( count + ARRAYSIZE(legacy_extensions) - 1 == size );
+        assert( count + ARRAY_SIZE(legacy_extensions) - 1 == size );
     }
 
     if (!disabled && !(disabled = query_opengl_option( "DisabledExtensions" ))) disabled = "";
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/9362

[Rémi Bernon]

On Wed Nov  5 10:27:55 2025 +0000, Rémi Bernon wrote:
> changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/9362/diffs?diff_id=221313&start_sha=95836fc3018db4f814d2e3dff4686d26507ccaf7#f4de89b6fe59a53c44625c669ffde0c88cf41d0b_1248_1244)
> Eh... right, got rid of it.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9362#note_120831