[PATCH 0/2] MR7145: windows.ui: Stub IUISettings3::add_ColorValuesChanged().

[Mohamad Al-Jaf (＠maljaf)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56983

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7145

[PATCH 1/2] windows.ui: Stub IUISettings3::add_ColorValuesChanged().

[Mohamad Al-Jaf]

From: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56983
---
 dlls/windows.ui/uisettings.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/dlls/windows.ui/uisettings.c b/dlls/windows.ui/uisettings.c
index b36194a2ac3..3d5988882db 100644
--- a/dlls/windows.ui/uisettings.c
+++ b/dlls/windows.ui/uisettings.c
@@ -23,6 +23,8 @@
 
 WINE_DEFAULT_DEBUG_CHANNEL(ui);
 
+static EventRegistrationToken dummy_cookie = {.value = 0xdeadbeef};
+
 struct uisettings
 {
     IUISettings IUISettings_iface;
@@ -357,7 +359,8 @@ static HRESULT WINAPI uisettings3_GetColorValue( IUISettings3 *iface, UIColorTyp
 static HRESULT WINAPI uisettings3_add_ColorValuesChanged( IUISettings3 *iface, ITypedEventHandler_UISettings_IInspectable *handler, EventRegistrationToken *cookie )
 {
     FIXME( "iface %p, handler %p, cookie %p stub!\n", iface, handler, cookie );
-    return E_NOTIMPL;
+    *cookie = dummy_cookie;
+    return S_OK;
 }
 
 static HRESULT WINAPI uisettings3_remove_ColorValuesChanged( IUISettings3 *iface, EventRegistrationToken cookie )
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/7145

[PATCH 2/2] windows.ui: Stub IUISettings3::remove_ColorValuesChanged().

[Mohamad Al-Jaf]

From: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com>

---
 dlls/windows.ui/uisettings.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/windows.ui/uisettings.c b/dlls/windows.ui/uisettings.c
index 3d5988882db..8ae4c912721 100644
--- a/dlls/windows.ui/uisettings.c
+++ b/dlls/windows.ui/uisettings.c
@@ -366,7 +366,7 @@ static HRESULT WINAPI uisettings3_add_ColorValuesChanged( IUISettings3 *iface, I
 static HRESULT WINAPI uisettings3_remove_ColorValuesChanged( IUISettings3 *iface, EventRegistrationToken cookie )
 {
     FIXME( "iface %p, cookie %#I64x stub!\n", iface, cookie.value );
-    return E_NOTIMPL;
+    return S_OK;
 }
 
 static const struct IUISettings3Vtbl uisettings3_vtbl =
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7145

[PATCH 2/2] windows.ui: Stub IUISettings3::remove_ColorValuesChanged().

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=150888

Your paranoid android.


=== debian11b (64 bit WoW report) ===

kernel32:
comm.c:1574: Test failed: AbortWaitCts hComPortEvent failed
comm.c:1586: Test failed: Unexpected time 1001, expected around 500

user32:
input.c:4305: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 00000000029800F6, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032

[PATCH 0/2] MR7145: windows.ui: Stub IUISettings3::add_ColorValuesChanged(). - approved

[Rémi Bernon]

This merge request was approved by Rémi Bernon.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7145