Re: [PATCH v4 0/1] MR516: tests: Print the failing line numbers when a test fails.

[Giovanni Mascellani (＠giomasce)]

On Fri Dec 22 23:04:14 2023 +0000, Petrichor Park wrote:
> OK, and this is because the code is *compiled* in `compile_shader`, but
> it's only checked for validity in the `STATE_PREPROC`? So it's showing
> the line where the preprocessing is done even though it "should" be
> showing the line where the compiling is done?
> I'd say the point is rather that, independently of whether you're testing compilation or preprocessing, while the parser is scanning the code section the code itself [is only copied line by line in buffer `shader_source`](https://gitlab.winehq.org/wine/vkd3d/-/blob/78343dcf87d3a911264c6c9a87a9146c...). Only then the following line beginning with `[` is found the parser knows that the section is finished and [can preprocess/compile it](https://gitlab.winehq.org/wine/vkd3d/-/blob/78343dcf87d3a911264c6c9a87a9146c...). By that moment the line number is that of the beginning of the following section, which might result in a misleading error message, unless you set a different context while the parser is [within the scope of `if (!ret || line[0] == '[')`](https://gitlab.winehq.org/wine/vkd3d/-/blob/78343dcf87d3a911264c6c9a87a9146c...).

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/516#note_56610