[PATCH 0/1] MR8429: ddraw/tests: Release device after ddraw.
Fix a use-after-free since device holds reference to ddraw surface, which in turn holds reference to ddraw. supersedes !8419 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8429
From: Yuxuan Shui <yshui(a)codeweavers.com> Fix a use-after-free since device holds reference to ddraw surface, which in turn holds reference to ddraw. --- dlls/ddraw/tests/ddraw2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c index d7daa4e989d..bac59a1949b 100644 --- a/dlls/ddraw/tests/ddraw2.c +++ b/dlls/ddraw/tests/ddraw2.c @@ -16922,8 +16922,8 @@ static void test_d3d_state_reset(void) IDirect3DViewport2_Release(viewport); IDirectDrawSurface_Release(surface); - IDirectDraw2_Release(ddraw); IDirect3DDevice2_Release(device); + IDirectDraw2_Release(ddraw); DestroyWindow(window); } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/8429
This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8429
This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8429
participants (4)
-
Elizabeth Figura (@zfigura) -
Jan Sikorski (@jsikorski) -
Yuxuan Shui -
Yuxuan Shui (@yshui)