Re: [PATCH v7 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec

[YuriK7 (＠riyu12383)]

On Sun Oct  1 23:56:05 2023 +0000, Alfred Agrell wrote:
> Yes, that is consistent with my experience. I tried Azumanga (everything
> looks good to me with this patch) and Touhou (crashes on Wine 8.17, Wine
> 8.17 with this patch, and Debian's Wine 8.0; different output before the
> crash, but they all segfault in
> SampleGrabber_ISampleGrabber_GetCurrentBuffer). Sounds like a different
> bug to me.
> The color bars are not a Wine bug; they're protonmediaconverter. It does
> that if it can't find a converted version of the media, which it can't
> if you're running it outside Steam. gstkrkr fills that exact hole.
> (gstkrkr also does a little trick to ensure ffmpeg's WMA audio decoder
> is selected instead of mediaconverter.)
> We tried to add the codec by adding --enable-decoder=mpegvideo,--enable-decoder=mpeg1video,--enable-decoder=mpeg2video and it still show the color bars... does it also need flags for the demuxer and parser in order to work ?

In your gstkrkr code you say that "in GStreamer, decoding a mpeg video requires three elements: mpegpsdemux ! mpegvideoparse ! avdec_mpeg2video" are those enabled by default if the ffmpeg flags are good ? We should enable them inside the GST_BAD_MESON_ARGS ? avdec_mpeg2video seems to be in the libav plugin.

We made those changes to https://github.com/GloriousEggroll/proton-ge-custom/blob/master/Makefile.in

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47406