[PATCH 0/1] MR220: vkd3d-shader/asm: Fix 3D samples declaration instruction name.

[Nikolay Sivov (＠nsivov)]

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/220

[PATCH 1/1] vkd3d-shader/asm: Fix 3D samples declaration instruction name.

[Nikolay Sivov]

From: Nikolay Sivov <nsivov(a)codeweavers.com>

---
 libs/vkd3d-shader/d3d_asm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libs/vkd3d-shader/d3d_asm.c b/libs/vkd3d-shader/d3d_asm.c
index 3357b4505..0a821b5c8 100644
--- a/libs/vkd3d-shader/d3d_asm.c
+++ b/libs/vkd3d-shader/d3d_asm.c
@@ -646,7 +646,7 @@ static void shader_dump_decl_usage(struct vkd3d_d3d_asm_compiler *compiler,
                 break;
 
             case VKD3D_SHADER_RESOURCE_TEXTURE_3D:
-                shader_addline(buffer, "_3d");
+                shader_addline(buffer, "_volume");
                 break;
 
             case VKD3D_SHADER_RESOURCE_TEXTURE_CUBE:
-- 
GitLab

https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/220

[PATCH 0/1] MR220: vkd3d-shader/asm: Fix 3D samples declaration instruction name. - approved

[Francisco Casas (＠fcasas)]

This merge request was approved by Francisco Casas.
-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/220

[Henri Verbeet (＠hverbeet)]

I think this is fine, but could you fix the commit message to say "sampler" instead of "samples"? (And if you're touching it anyway, I think we'd like the prefix to be "vkd3d-shader/d3d-asm".)

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/220#note_34350