[PATCH v2 0/1] MR4666: gdiplus: Prevent uninitializd memory access (Coverity)

[Fabian Maurer (＠DarkShadow44)]

--
  v2: gdiplus: Prevent uninitializd memory access (Coverity)
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4666

[PATCH v2 1/1] gdiplus: Prevent uninitializd memory access (Coverity)

[Fabian Maurer]

From: Fabian Maurer <dark.shadow4(a)web.de>

---
 dlls/gdiplus/metafile.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/gdiplus/metafile.c b/dlls/gdiplus/metafile.c
index eb8b4197f3f..fdd88ad2f10 100644
--- a/dlls/gdiplus/metafile.c
+++ b/dlls/gdiplus/metafile.c
@@ -3404,6 +3404,8 @@ GpStatus WINGDIPAPI GdipPlayMetafileRecord(GDIPCONST GpMetafile *metafile,
                 {
                     if (flags & 0x800) /* P */
                     {
+                        points[0].X = fill->PointData.pointsR[0].X;;
+                        points[0].Y = fill->PointData.pointsR[0].Y;
                         for (i = 1; i < fill->Count; i++)
                         {
                             points[i].X = points[i - 1].X + fill->PointData.pointsR[i].X;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4666

[PATCH v2 1/1] gdiplus: Prevent uninitializd memory access (Coverity)

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=141087

Your paranoid android.


=== debian11b (64 bit WoW report) ===

winhttp:
notification.c:1112: Test failed: unexpected data 0x82 at 3278

[Fabian Maurer (＠DarkShadow44)]

I assume this is the wanted behavior, using uninitialized memory seems wrong in any case. Can you please check?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4666#note_55652