Re: [PATCH v13 0/1] MR6453: emfdc: avoid memory leaks in get_bitmap_info
11 Sep
2024
11 Sep
'24
4:44 p.m.
Jacek Caban (@jacek) commented about dlls/gdi32/emfdc.c:
{ blit_dc = *hdc; blit_bitmap = *bitmap; + + if (!GetDIBits( blit_dc, blit_bitmap, 0, INT_MAX, NULL, info, DIB_RGB_COLORS )) + goto err;
You could just return 0 here, which would allow you to simplify the code some more. Then you don't need the assignment above. And without that assignment, we could remove `blit_dc != *hdc` check from error handling path. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6453#note_81916
540
Age (days ago)
540
Last active (days ago)
0 comments
1 participants
participants (1)
-
Jacek Caban (@jacek)