[PATCH v2 0/1] MR3937: d3dx9_36: Trace pointer not the object

[Alistair Leslie-Hughes (＠alesliehughes)]

--
  v2: d3dx9: D3DXValidMesh - Trace pointer not the object
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3937

[PATCH v2 1/1] d3dx9: D3DXValidMesh - Trace pointer not the object

[Alistair Leslie-Hughes]

From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>

---
 dlls/d3dx9_36/mesh.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/d3dx9_36/mesh.c b/dlls/d3dx9_36/mesh.c
index 47a0cadde67..9b17dd91765 100644
--- a/dlls/d3dx9_36/mesh.c
+++ b/dlls/d3dx9_36/mesh.c
@@ -6464,7 +6464,7 @@ error:
 
 HRESULT WINAPI D3DXValidMesh(ID3DXMesh *mesh, const DWORD *adjacency, ID3DXBuffer **errors_and_warnings)
 {
-    FIXME("(%p, %p, %p): stub\n", mesh, adjacency, *errors_and_warnings);
+    FIXME("(mesh %p, adjacency %p, errors_and_warnings %p): stub\n", mesh, adjacency, errors_and_warnings);
 
     return E_NOTIMPL;
 }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3937

[PATCH v2 1/1] d3dx9: D3DXValidMesh - Trace pointer not the object

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=137866

Your paranoid android.


=== debian11b (64 bit WoW report) ===

windows.media.speech:
Unhandled exception: page fault on execute access to 0x0000000000000000 in 64-bit code (0000000000000000).

[Matteo Bruni (＠Mystral)]

On Tue Sep 26 18:42:32 2023 +0000, Alistair Leslie-Hughes wrote:
> changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/3937/diffs?diff_id=71979&start_sha=17055949a8d32dd4231b6b442dd812f30838f965#90c8bf9624d3de289000d4ecf99d49941eb4823e_6467_6467)
    FIXME("(%p, %p, %p): stub\n", mesh, adjacency, errors_and_warnings);
    FIXME("mesh %p, adjacency %p, errors_and_warnings %p stub.\n", mesh, adjacency, errors_and_warnings);

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3937#note_46842