Re: [PATCH v2 0/2] MR1135: msvcrt: _[w]putenv_s return value fix
22 Oct
2022
22 Oct
'22
6:40 a.m.
Chip Davis (@cdavis5e) commented about dlls/msvcrt/environ.c:
/********************************************************************* * _wputenv_s (MSVCRT.@) */ -int CDECL _wputenv_s(const wchar_t *name, const wchar_t *value) +errno_t CDECL _wputenv_s(const wchar_t *name, const wchar_t *value) { - int ret; + errno_t ret = 0;
TRACE("%s %s\n", debugstr_w(name), debugstr_w(value));
if (!MSVCRT_CHECK_PMT(name != NULL)) return -1; if (!MSVCRT_CHECK_PMT(value != NULL)) return -1; I hate to be the bearer of bad news, since this was already merged, but it looks like you missed these two.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1135#note_11787
1156
Age (days ago)
1156
Last active (days ago)
0 comments
1 participants
participants (1)
-
Chip Davis (@cdavis5e)