[PATCH v2 0/1] MR4149: msxml: Always increase error count when detect

[Alistair Leslie-Hughes (＠alesliehughes)]

The error count wasn't be increased if tracing was disabled. eg CI.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55720

--
  v2: msxml: Always increase error count when detected
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4149

[PATCH v2 1/1] msxml: Always increase error count when detected

[Alistair Leslie-Hughes]

From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>

The error count wasn't be increased if tracing was disabled. eg CI.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55720
---
 dlls/msxml3/xslpattern.y | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/msxml3/xslpattern.y b/dlls/msxml3/xslpattern.y
index 9abf43cad35..b308c3150b0 100644
--- a/dlls/msxml3/xslpattern.y
+++ b/dlls/msxml3/xslpattern.y
@@ -40,6 +40,7 @@ static inline BOOL is_literal(xmlChar const* tok)
 
 static void xslpattern_error(parser_param* param, void const* scanner, char const* msg)
 {
+    param->err++;
     FIXME("%s:\n"
           "  param {\n"
           "    yyscanner=%p\n"
@@ -52,7 +53,7 @@ static void xslpattern_error(parser_param* param, void const* scanner, char cons
           "  }\n"
           "  scanner=%p\n",
           msg, param->yyscanner, param->ctx, param->in, param->pos,
-          param->len, param->out, ++param->err, scanner);
+          param->len, param->out, param->err, scanner);
 }
 
 %}
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4149

[PATCH v2 1/1] msxml: Always increase error count when detected

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=138929

Your paranoid android.


=== debian11b (64 bit WoW report) ===

user32:
input.c:1291: Test failed: Unexpected vkCode 0xa4, expected 0xe7.

[PATCH v2 0/1] MR4149: msxml: Always increase error count when detected. - approved

[Nikolay Sivov (＠nsivov)]

This merge request was approved by Nikolay Sivov.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4149