[PATCH v2 0/9] MR9206: d3dx11: Import more tests from d3dx10 and implement D3DX11CreateTextureFromMemory() using shared code.

newer
Re: [PATCH v5 0/1] MR8988: win32u:...

Connor McAdams (＠cmcadams)

28 Oct 2025 28 Oct '25

3:34 p.m.

The test code here is pulled in from the d3dx10 tests, with some variable name changes to work around existing d3dx11 test definitions and a removal of a few `broken()`s for Windows Vista since we no longer test on it. -- v2: d3dx11: Implement D3DX11CreateTextureFromMemory() using shared code. d3dx11/tests: Import test_create_texture() from d3dx10. d3dx11/tests: Import test_get_image_info() from d3dx10. d3dx11/tests: Rearrange and reformat tests to more closely match d3dx10 tests. d3dx11: Add stubs for D3DX11CreateTextureFromResource{A,W}(). d3dx11: Add stubs for D3DX11GetImageInfoFromResource{A,W}(). d3dx10/tests: Cleanup test image definitions. d3dx10/tests: Get rid of broken() workarounds for Vista. d3dx10: Downgrade invalid filter trace from an ERR to a WARN. https://gitlab.winehq.org/wine/wine/-/merge_requests/9206

Show replies by date

Connor McAdams

28 Oct 28 Oct

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9206#note_119888

Connor McAdams (＠cmcadams)

3:37 p.m.

On Tue Oct 28 15:34:46 2025 +0000, Connor McAdams wrote:

...

changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/9206/diffs?diff_id=219236&start_sha=5cb7dd999047a6d787849bfe01797bfc8de9975e#ff8d877b3fa2ee9358ccaa06bf845be64a51d059_276_179) I've changed them all to `uint8_t`. :smiling_imp:

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9206#note_119889

Connor McAdams (＠cmcadams)

3:39 p.m.

On Tue Oct 28 15:39:55 2025 +0000, Matteo Bruni wrote:

...

Sorry I didn't get to this sooner. I left some comments with the general idea of keeping the d3dx10/11 tests as close as possible, now and going forward. Ideally it would be possible to do `diff -u dlls/d3dx10_43/tests/d3dx10.c dlls/d3dx11_43/tests/d3dx11.c` and quickly discern trivial differences (mainly all the s/10/11/) from "intended" ones. It's all good :)

I've added quite a few patches here to rearrange and rework the tests to be more synchronized between d3dx10/d3dx11. Hopefully this improves things, I did a quick `diff -u dlls/d3dx10_43/tests/d3dx10.c dlls/d3dx11_43/tests/d3dx11.c` myself and it seems easier to tell apart the differences between the tests that are shared. Sorry if the extra patches end up being more review work, but hopefully it makes things easier down the line. :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9206#note_119891

Matteo Bruni (＠Mystral)

4 Nov 4 Nov

11:29 a.m.

New subject: [PATCH v2 0/9] MR9206: d3dx11: Import more tests from d3dx10 and implement D3DX11CreateTextureFromMemory() using shared code. - approved

This merge request was approved by Matteo Bruni. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9206

Matteo Bruni (＠Mystral)

11:33 a.m.

Cleanup ideas for follow up: - we could probably reuse `check_texture2d_desc_()` / `check_texture3d_desc_()` in `check_resource_info()` - we could "merge" `check_readback_data_u32_()` + `check_texture_sub_resource_u32_()` with `check_texture2d_data()` + `check_texture3d_data()` + `check_resource_data()`. The former expect the sub resource to have a uniform color, the latter pass a `struct test_image` with the whole texture data to be compared. These are just ideas, it's certainly possible that it's not worth it (i.e. my armchair guess is that the `check_resource_info()` one is simple enough, the readback one probably too messy) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9206#note_120681

Age (days ago)

Last active (days ago)

List overview

Download

14 comments

3 participants

participants (3)

Connor McAdams
Connor McAdams (＠cmcadams)
Matteo Bruni (＠Mystral)

[PATCH v2 0/9] MR9206: d3dx11: Import more tests from d3dx10 and implement D3DX11CreateTextureFromMemory() using shared code.

tags

participants (3)