[PATCH 0/1] MR7046: mshtml: Ignore Gecko events on detached nodes.

[Jacek Caban (＠jacek)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57248

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7046

[PATCH 1/1] mshtml: Ignore Gecko events on detached nodes.

[Jacek Caban]

From: Jacek Caban <jacek(a)codeweavers.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57248
---
 dlls/mshtml/nsevents.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/mshtml/nsevents.c b/dlls/mshtml/nsevents.c
index 77622c57bbc..5d52cf4f17a 100644
--- a/dlls/mshtml/nsevents.c
+++ b/dlls/mshtml/nsevents.c
@@ -441,7 +441,7 @@ static nsresult handle_htmlevent(HTMLDocumentNode *doc, nsIDOMEvent *nsevent)
     }else {
         hres = get_node(nsnode, TRUE, &node);
         nsIDOMNode_Release(nsnode);
-        if(FAILED(hres))
+        if(FAILED(hres) || !node->doc->script_global)
             return NS_OK;
         target = &node->event_target;
     }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7046

[PATCH 1/1] mshtml: Ignore Gecko events on detached nodes.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=150451

Your paranoid android.


=== debian11b (64 bit WoW report) ===

user32:
input.c:4305: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 00000000005600FA, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032
msg.c:12676: Test failed: Got expected 0.
msg.c:12691: Test failed: Got expected 0.