[PATCH 0/1] MR3015: winhttp: Fix double free on error path in queue_task (scan-build).

[Alex Henrie (＠alexhenrie)]

queue_task cannot free the struct because it doesn't know whether the
struct contains pointers to other dynamically allocated memory that also
needs to be freed (as is the case with struct send_request).

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3015

[PATCH 1/1] winhttp: Fix double free on error path in queue_task (scan-build).

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

queue_task cannot free the struct because it doesn't know whether the
struct contains pointers to other dynamically allocated memory that also
needs to be freed (as is the case with struct send_request).
---
 dlls/winhttp/request.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/dlls/winhttp/request.c b/dlls/winhttp/request.c
index 07d0ff19b7c..cf091244002 100644
--- a/dlls/winhttp/request.c
+++ b/dlls/winhttp/request.c
@@ -218,7 +218,6 @@ static DWORD queue_task( struct queue *queue, TASK_CALLBACK task, struct task_he
     if (!callback_running)
     {
         release_object( obj );
-        free( task_hdr );
         ERR( "Submiting threadpool callback failed, err %lu.\n", GetLastError() );
         return ERROR_OUTOFMEMORY;
     }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3015

[PATCH 0/1] MR3015: winhttp: Fix double free on error path in queue_task (scan-build). - approved

[Hans Leidekker (＠hans)]

This merge request was approved by Hans Leidekker.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3015