[PATCH v2 0/1] MR4873: ntdll: Add comment regarding nt_path passed to server for built-in dlls
-- v2: ntdll: Add comment regarding nt_path passed to server for built-in dlls https://gitlab.winehq.org/wine/wine/-/merge_requests/4873
From: Fabian Maurer <dark.shadow4(a)web.de> --- dlls/ntdll/unix/loader.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/dlls/ntdll/unix/loader.c b/dlls/ntdll/unix/loader.c index 803d8079213..5ab33d447ea 100644 --- a/dlls/ntdll/unix/loader.c +++ b/dlls/ntdll/unix/loader.c @@ -1190,6 +1190,12 @@ static NTSTATUS find_builtin_dll( UNICODE_STRING *nt_name, void **module, SIZE_T } file[--pos] = '/'; + /* + * When loading a builtin dll we still use the original nt_path for the object attributes. + * This may lead to the nt_path being different from the unix path, this is intentional. + * This is done because the application should not know the dll was substituted with a builtin one. + */ + if (build_dir) { /* try as a dll */ -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/4873
On Mon Jan 22 21:16:18 2024 +0000, Alexandre Julliard wrote:
If there's a real anti-cheat that does this, the dll would have to be configured native. Still, we don't want to expose the internal path. Note that it may not even be a valid dll in case of a non-PE build. Alright, thanks for the clarification. I changed the MR to just add a comment, in case someone stumbles across the same "issue" as me. If you don't feel this is necessary, feel free to close.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4873#note_58545
This merge request was closed by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4873
participants (3)
-
Alexandre Julliard (＠julliard) -
Fabian Maurer
-
Fabian Maurer (＠DarkShadow44)