[PATCH 0/1] MR7440: dwrite: Use Noto Sans as fallback for General and Supplemental Punctuation.
From: Daniel Lehman <dlehman25(a)gmail.com> --- dlls/dwrite/analyzer.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/dlls/dwrite/analyzer.c b/dlls/dwrite/analyzer.c index 92ffc8ffe1e..b70a667a2cb 100644 --- a/dlls/dwrite/analyzer.c +++ b/dlls/dwrite/analyzer.c @@ -292,6 +292,11 @@ system_fallback_config[] = { "1C00-1C4F", L"Noto Sans Lepcha" }, { "1C50-1C7F", L"Noto Sans Ol Chiki" }, + /* General Punctuation - 2000-206F + Supplemental Punctuation - 2E00-2E7F */ + + { "2000-206F, 2E00-2E7F", L"Noto Sans" }, + { "2C80-2CFF", L"Noto Sans Coptic" }, { "2D30-2D7F", L"Noto Sans Tifinagh" }, -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/7440
I'm attaching a revised version for CJK locales, it has to use consistent font in such cases.[dwrite.diff](/uploads/b42f1765b0a77e148a7d6c8b0b2bfbf7/dwrite.diff) Note that it's excluding 202F because it's handled explicitly together with Mongolian ranges. This does not cover all of your changes. We need a non-locale specific entry for the same set "2000-202E, 2030-206F, 2E00-2E44". Now that has options, we could use Tahoma for those (Windows font does cover this), or we could switch all existing "common" ranges (first entry in this list) to Noto Sans. A variant of this second option is to use both names - "Tahoma, Noto Sans". Switching to Noto Sans will switch UI font in some cases, when applications are using e.g. Segoe UI that we don't have; this will be a visible change potentially for users who are used to current setup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7440#note_96200
Now that has options
have a preference?
A variant of this second option is to use both names - "Tahoma, Noto Sans"
you mean something like? ```c /* Latin, Combining Diacritical Marks */ { "0000-007F, 0080-00FF, 0100-017F, 0180-024F, " - "0250-02AF, 02B0-02FF, 0300-036F", L"Tahoma" }, + "0250-02AF, 02B0-02FF, 0300-036F, " + "2000-202E, 2030-206F, 2E00-2E44", L"Tahoma, Noto Sans" }, { "0530-058F, FB10-FB1C", L"Noto Sans Armenian" }, ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7440#note_96219
On Fri Feb 28 14:43:47 2025 +0000, Daniel Lehman wrote:
Now that has options have a preference? A variant of this second option is to use both names - "Tahoma, Noto Sans" you mean something like?
/* Latin, Combining Diacritical Marks */ { "0000-007F, 0080-00FF, 0100-017F, 0180-024F, " - "0250-02AF, 02B0-02FF, 0300-036F", L"Tahoma" }, + "0250-02AF, 02B0-02FF, 0300-036F, " + "2000-202E, 2030-206F, 2E00-2E44", L"Tahoma, Noto Sans" }, { "0530-058F, FB10-FB1C", L"Noto Sans Armenian" },Yes, exactly. Regarding preferred way, if we use Tahoma with additional ranges we'll get null glyphs when we miss some glyph in wine's Tahoma. If we use both names we'll have potentially text switching from one font to another for no obvious reason to the user. If we use Noto Sans for everything, all ranges will work, but this will change default config that we had so far.
Maybe we could use "Noto Sans, Tahoma" instead? Does that make sense? On mac for example you're not going to get Noto Sans semi-automatically. What is your use case, do you need anything from those ranges or you only need non-null font instance? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7440#note_96220
Maybe we could use "Noto Sans, Tahoma" instead? Does that make sense?
seems consistent with the other entries that use Noto Sans
What is your use case, do you need anything from those ranges
0x2e2e prompted the change, but would like to add a general range -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7440#note_96221
On Fri Feb 28 15:03:51 2025 +0000, Daniel Lehman wrote:
Maybe we could use "Noto Sans, Tahoma" instead? Does that make sense? seems consistent with the other entries that use Noto Sans What is your use case, do you need anything from those ranges 0x2e2e prompted the change, but would like to add a general range Both Noto Sans and Tahoma (on Windows) have it, so let's go with "Noto Sans, Tahoma" and see how it goes.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7440#note_96304
participants (3)
-
Daniel Lehman -
Daniel Lehman (＠dlehman25)
-
Nikolay Sivov (＠nsivov)