Re: [PATCH v7 0/1] MR10174: bcryptprimitives: Abort if `ProcessPrng` fails

25 Feb 2026


      On Wed Feb 25 14:26:15 2026 +0000, Paul Gofman wrote:
...
Note that we can't protect things this way securely anyway. E. g., if
app does random memory access and hits our random data buffer used in
SystemFunction36, this won't be detected by return value check.
The point of having an abort in the function is not security in itself. The aborting code path should never be hit. If it is then it's a bug in the underlying implementation that should *ideally* be fixed. And if such a bug does occur then users shouldn't rely on it (even if unintentionally). So the `abort` ensure the function fulfils the documented behaviour even if something else goes wrong.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10174#note_130505

Christopher Denton (＠cdenton)

tags

participants (1)