[PATCH 0/1] MR9334: comctl32/tests: Terminate string literal by double null character (ASan).

[Bernhard Übelacker]

The TB_ADDSTRINGA expects the last string to be terminated by two null characters, to be able to detect the array end.

[ASan report details](https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2025-10-18_wine-10.1...)

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9334

[PATCH 1/1] comctl32/tests: Terminate string literal by double null character (ASan).

[Bernhard Übelacker]

From: Bernhard Übelacker <bernhardu(a)mailbox.org>

---
 dlls/comctl32/tests/toolbar.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/comctl32/tests/toolbar.c b/dlls/comctl32/tests/toolbar.c
index 0a66cc64782..97d6acb781f 100644
--- a/dlls/comctl32/tests/toolbar.c
+++ b/dlls/comctl32/tests/toolbar.c
@@ -2143,7 +2143,7 @@ static void test_getstring(void)
     expect(-1, r);
     r = SendMessageW(hToolbar, TB_GETSTRINGW, MAKEWPARAM(0, 0), 0);
     expect(-1, r);
-    r = SendMessageA(hToolbar, TB_ADDSTRINGA, 0, (LPARAM)"STR");
+    r = SendMessageA(hToolbar, TB_ADDSTRINGA, 0, (LPARAM)"STR\0");
     expect(0, r);
     r = SendMessageA(hToolbar, TB_GETSTRINGA, MAKEWPARAM(0, 0), 0);
     ok(r == 3, "Unexpected return value %d.\n", r);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/9334

[PATCH 0/1] MR9334: comctl32/tests: Terminate string literal by double null character (ASan). - approved

[Nikolay Sivov (＠nsivov)]

This merge request was approved by Nikolay Sivov.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9334

[PATCH 0/1] MR9334: comctl32/tests: Terminate string literal by double null character (ASan). - approved

[Zhiyi Zhang (＠zhiyi)]

This merge request was approved by Zhiyi Zhang.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9334