[PATCH 0/1] MR1354: server: Remove no-op raw_msg.foreground release.

[Rémi Bernon]

It's previously initialized to NULL and never updated.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1354

[PATCH 1/1] server: Remove no-op raw_msg.foreground release.

[Rémi Bernon]

From: Rémi Bernon <rbernon(a)codeweavers.com>

It's previously set to NULL and never updated.
---
 server/queue.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/server/queue.c b/server/queue.c
index 01fe8d6c060..22f720530b9 100644
--- a/server/queue.c
+++ b/server/queue.c
@@ -2043,8 +2043,6 @@ static void queue_custom_hardware_message( struct desktop *desktop, user_handle_
         msg_data->rawinput = input->hw.rawinput;
 
         enum_processes( queue_rawinput_message, &raw_msg );
-
-        if (raw_msg.foreground) release_object( raw_msg.foreground );
         return;
     }
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1354

[PATCH 1/1] server: Remove no-op raw_msg.foreground release.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=126130

Your paranoid android.


=== debian11 (32 bit report) ===

crypt32:
cert.c:4191: Test failed: success
cert.c:4192: Test failed: got 00000000
cert.c:4193: Test failed: got 00000000

wmvcore:
wmvcore.c:2997: Test failed: Wait timed out.