Re: [PATCH v3 0/2] MR9704: winmm, msvfw32: DGV window shenanigans with audio only files

[Huw Davies (＠huw)]

Huw Davies (@huw) commented about dlls/winmm/tests/mci.c:
> -static void test_playWaveTypeMpegvideo(void)
> +static void test_playTypeMpegvideo(HWND hwnd)
>  {
> +    const WCHAR *filename = load_resource(L"test.mp3");
> +    MCI_DGV_WINDOW_PARMSW window_param = { 0 };
> +    MCI_STATUS_PARMS status_parm = { 0 };
> +    MCI_PLAY_PARMS play_parm = { 0 };
> +    MCIDEVICEID wDeviceID = 0;
> +    char buf[1024] = { 0 };
>      MCIERROR err;
> -    MCIDEVICEID wDeviceID;
> -    MCI_PLAY_PARMS play_parm;
> -    MCI_STATUS_PARMS status_parm;
> -    char buf[1024];
> -    memset(buf, 0, sizeof(buf));

Please don't make these kind of changes, just add the vars you need, only init them if need be and don't try to Christmas tree them.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9704#note_130483