Re: [PATCH v6 0/4] MR6423: Implement NtQuerySystemEnvironmentValueEx, NtQuerySystemInformation SystemBootEnvironmentInformation, GetFirmwareType, GetFirmwareEnvironmentVariable*

[Alfred Agrell (＠Alcaro)]

Alfred Agrell (@Alcaro) commented about dlls/kernel32/process.c:
> +        return FALSE;
> +    return TRUE;
> +}
> +
> +static const BYTE __wine_guid_conv_table[256] =
> +{
> +    0,   0,   0,   0,   0,   0,   0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* 0x00 */
> +    0,   0,   0,   0,   0,   0,   0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* 0x10 */
> +    0,   0,   0,   0,   0,   0,   0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* 0x20 */
> +    0,   1,   2,   3,   4,   5,   6, 7, 8, 9, 0, 0, 0, 0, 0, 0, /* 0x30 */
> +    0, 0xa, 0xb, 0xc, 0xd, 0xe, 0xf, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* 0x40 */
> +    0,   0,   0,   0,   0,   0,   0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* 0x50 */
> +    0, 0xa, 0xb, 0xc, 0xd, 0xe, 0xf                             /* 0x60 */
> +};
> +
> +static inline BOOL __wine_guid_from_string(LPCWSTR s, GUID *id)
> You've reinvented RtlGUIDFromString(). Better call that.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6423#note_81247