[PATCH 0/1] MR6154: dbghelp: fixed misprint access to struct with invalid case

[Herman Semenov (＠GermanAizek)]

Typo is immediately noticeable here, since the case value has postfix digit 2.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6154

[PATCH 1/1] dbghelp: fixed misprint access to struct with invalid case

[Herman Semenov]

From: Herman Semenov <GermanAizek(a)yandex.ru>

---
 dlls/dbghelp/msc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/dbghelp/msc.c b/dlls/dbghelp/msc.c
index 6250061296e..e4a63544f34 100644
--- a/dlls/dbghelp/msc.c
+++ b/dlls/dbghelp/msc.c
@@ -2712,7 +2712,7 @@ static BOOL codeview_snarf(const struct msc_debug_info* msc_dbg,
                     /* skip all records until paired S_INLINESITE_END */
                     sym = (const union codeview_symbol*)(root + sym->inline_site2_v3.pEnd);
                     if (sym->generic.id != S_INLINESITE_END) FIXME("complete wreckage\n");
-                    length = sym->inline_site_v3.pEnd - i + sym->generic.len;
+                    length = sym->inline_site2_v3.pEnd - i + sym->generic.len;
                 }
             }
             break;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6154

[eric pouech (＠epo)]

thanks for fixing the typo (note that the field offset of pEnd is the same in two structures, so this won't have impact on compiled code)

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6154#note_77037

[PATCH 0/1] MR6154: dbghelp: fixed misprint access to struct with invalid case - approved

[eric pouech (＠epo)]

This merge request was approved by eric pouech.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6154