[PATCH 0/1] MR3837: quartz/tests: Fix segfault in changed3ddevice test.

[Alfred Agrell (＠Alcaro)]

Fixes regression from https://gitlab.winehq.org/wine/wine/-/merge_requests/3792

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3837

[PATCH 1/1] quartz/tests: Fix segfault in changed3ddevice test.

[Alfred Agrell]

From: Alfred Agrell <floating(a)muncher.se>

---
 dlls/quartz/tests/vmr9.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/dlls/quartz/tests/vmr9.c b/dlls/quartz/tests/vmr9.c
index 6e566f39c58..447273a91df 100644
--- a/dlls/quartz/tests/vmr9.c
+++ b/dlls/quartz/tests/vmr9.c
@@ -4335,10 +4335,10 @@ static void test_changed3ddevice(void)
     IDirect3DDevice9 *device, *device2;
     RECT rect = {0, 0, 640, 480};
     struct testfilter source;
+    IPin *pin = NULL;
     HWND window;
     HRESULT hr;
     ULONG ref;
-    IPin *pin;
 
     testfilter_init(&source);
 
@@ -4386,7 +4386,8 @@ static void test_changed3ddevice(void)
     IDirect3DDevice9_Release(device2);
 
 out:
-    IPin_Release(pin);
+    if (pin)
+        IPin_Release(pin);
     ref = IFilterGraph2_Release(graph);
     ok(!ref, "Got outstanding refcount %ld.\n", ref);
     IVMRSurfaceAllocatorNotify9_Release(notify);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3837

[PATCH 1/1] quartz/tests: Fix segfault in changed3ddevice test.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=137379

Your paranoid android.


=== w10pro64_en_AE_u8 (64 bit report) ===

quartz:
vmr9.c:1206: Test failed: Got hr 0x40237.
vmr9.c:1212: Test failed: Got hr 0x1.

[PATCH 1/1] quartz/tests: Fix segfault in changed3ddevice test.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

3 TestBot errors prevented a full analysis of your patch.
If the test caused the operating system (e.g. Windows) to crash or
reboot you will probably have to modify it to avoid that.
Other issues should be reported to the TestBot administrators.

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=151953

Your paranoid android.


=== build (build log) ===

WineRunBuild.pl:error: Could not copy the patch to the VM: network read timed out (sendfile/connect:AgentVersion.h:0/9)
WineRunBuild.pl:error: BotError: The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)

=== debian11 (build log) ===

WineRunWineTest.pl:error: Could not send 'patch.diff' to the VM: network read timed out (sendfile/connect:AgentVersion.h:0/9)
WineRunWineTest.pl:error: BotError: The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)
WineRunWineTest.pl:error: Giving up after 3 run(s)

=== debian11b (build log) ===

WineRunWineTest.pl:error: Could not send 'patch.diff' to the VM: network read timed out (sendfile/connect:AgentVersion.h:0/9)
WineRunWineTest.pl:error: BotError: The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)
WineRunWineTest.pl:error: Giving up after 3 run(s)

[PATCH 0/1] MR3837: quartz/tests: Fix segfault in changed3ddevice test. - approved

[Zebediah Figura (＠zfigura)]

This merge request was approved by Zebediah Figura.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3837