Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/bcrypt/gnutls.c:
> gnutls_datum_t label;
>
> -        if (!pad || !pad->pszAlgId || !pad->pbLabel)
> +        /* Size-only OAEP queries can succeed without padding info, but an actual
> +         * OAEP encryption call requires padding info on native Windows. */
> +        if (!pad)
>          {
>              WARN( "padding info not found\n" );
>              return STATUS_INVALID_PARAMETER;
>          }
> +
> +        if (!pad->pszAlgId)
> +        {
> +            WARN( "padding hash not found\n" );
> +            return STATUS_INVALID_PARAMETER;
> +        }

Splitting these checks just to print a slightly different message is not worth it. This is unlikely to happen.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130901