[PATCH 0/1] MR9606: cmd: Add ':' to delimiters for tab-completion support.
Fixes 'z:fil<tab>' -> 'z:files.txt', etc. Without this change, 'z:fil<tab>' would be completed to 'files.txt' (i.e. the 'z:' would be overwritten). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9606
From: Joe Souza <jsouza(a)yahoo.com> Fixes 'z:fil<tab>' -> 'z:files.txt', etc. --- programs/cmd/wcmdmain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/programs/cmd/wcmdmain.c b/programs/cmd/wcmdmain.c index 1eb40d46644..41790edd4e9 100644 --- a/programs/cmd/wcmdmain.c +++ b/programs/cmd/wcmdmain.c @@ -33,9 +33,10 @@ WINE_DEFAULT_DEBUG_CHANNEL(cmd); +/* Delimiters for tab-completion support */ #define BASE_DELIMS L",=;~!^&()+{}[]" #define PATH_SEPARATION_DELIMS L" " BASE_DELIMS -#define INTRA_PATH_DELIMS L"\\" BASE_DELIMS +#define INTRA_PATH_DELIMS L"\\:" BASE_DELIMS typedef struct _SEARCH_CONTEXT { -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/9606
hmm the fact that c: disapears without this MR doesn't look good at all and shows other issues could you please also consider and fix these cases: * dir \\wind\<tab\> is not completed on Wine while it's on Windows (likely different issue) * dir c+\\wind\<tab\> is completed on windows as dir c+\\windows (while Wine likely erases the c+) (but requires first item to be fixed first) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9606#note_123961
On Thu Nov 27 19:35:23 2025 +0000, eric pouech wrote:
hmm the fact that c: disapears without this MR doesn't look good at all and shows other issues could you please also consider and fix these cases: * dir \\wind\<tab\> is not completed on Wine while it's on Windows (likely different issue) * dir c+\\wind\<tab\> is completed on windows as dir c+\\windows (while Wine likely erases the c+) (but requires first item to be fixed first) Both of the cases you mention are working for me with current code. Are you testing with an older version of Wine?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9606#note_123976
This merge request was approved by eric pouech. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9606
On Thu Nov 27 19:35:23 2025 +0000, Joe Souza wrote:
Both of the cases you mention are working for me with current code. Are you testing with an older version of Wine? hmmm yes... looks like I tested on z: instead of c:
sorry about the noise -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9606#note_124019
participants (3)
-
eric pouech (＠epo) -
Joe Souza
-
Joe Souza (＠JoeS209)