[PATCH v2 0/1] MR10230: combase: Add RoFailFastWithErrorContext stub

[Alistair Leslie-Hughes (＠alesliehughes)]

--
  v2: combase: Add RoFailFastWithErrorContext stub
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10230

[PATCH v2 1/1] combase: Add RoFailFastWithErrorContext stub

[Alistair Leslie-Hughes]

From: Alistair Leslie-Hughes <[e-mail]>

---
 dlls/combase/combase.spec | 2 +-
 dlls/combase/roapi.c      | 9 +++++++++
 include/roerrorapi.h      | 1 +
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/dlls/combase/combase.spec b/dlls/combase/combase.spec
index 9018b013823..0a995a2e70e 100644
--- a/dlls/combase/combase.spec
+++ b/dlls/combase/combase.spec
@@ -290,7 +290,7 @@
 @ stdcall RoActivateInstance(ptr ptr)
 @ stub RoCaptureErrorContext
 @ stub RoClearError
-@ stub RoFailFastWithErrorContext
+@ stdcall RoFailFastWithErrorContext(long)
 @ stub RoFreeParameterizedTypeExtra
 @ stub RoGetActivatableClassRegistration
 @ stdcall RoGetActivationFactory(ptr ptr ptr)
diff --git a/dlls/combase/roapi.c b/dlls/combase/roapi.c
index a88181ada9b..f4f7c0aac26 100644
--- a/dlls/combase/roapi.c
+++ b/dlls/combase/roapi.c
@@ -588,3 +588,12 @@ HRESULT WINAPI DllGetActivationFactory(HSTRING classid, IActivationFactory **fac
 
     return REGDB_E_CLASSNOTREG;
 }
+
+/***********************************************************************
+ *      RoFailFastWithErrorContext (combase.@)
+ */
+void WINAPI RoFailFastWithErrorContext(HRESULT hr)
+{
+    FIXME("(0x%08lx)\n", hr);
+    RaiseFailFastException(NULL, NULL, 0);
+}
diff --git a/include/roerrorapi.h b/include/roerrorapi.h
index 8f3200c559d..0bab6651d2b 100644
--- a/include/roerrorapi.h
+++ b/include/roerrorapi.h
@@ -33,6 +33,7 @@ typedef enum
 } RO_ERROR_REPORTING_FLAGS;
 
 HRESULT WINAPI GetRestrictedErrorInfo(IRestrictedErrorInfo **info);
+void    WINAPI RoFailFastWithErrorContext(HRESULT hr);
 HRESULT WINAPI RoGetErrorReportingFlags(UINT32 *flags);
 BOOL    WINAPI RoOriginateError(HRESULT error, HSTRING message);
 BOOL    WINAPI RoOriginateErrorW(HRESULT error, UINT max_len, const WCHAR *message);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/10230

[Alfred Agrell (＠Alcaro)]

On Tue Mar  3 00:00:12 2026 +0000, Alfred Agrell wrote:
> Anything named FailFast being able to return makes me nervous. I'd
> rather see an abort() or TerminateProcess(self, 1) or something after
> the fixme.
> But I'm not entirely sure what Wine's stub policy is. If it says
> something contrary, ignore me.
> Yep, that's a satisfactory something.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10230#note_131038