[PATCH v2 0/1] MR2771: winestreamer: Don't set twice the same format in stream description.

[eric pouech (＠epo)]

Prior to 98d209752cee9abd8dc31dfe1f28811066b0b83f, the base type format
wasn't inserted twice in stream format description.
An application (Idol Showdown) fails to play its intro video when the
base type format is duplicated.

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com>

--
  v2: winestreamer: Fix type.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2771

[PATCH v2 1/1] winestreamer: Fix type.

[Eric Pouech]

From: Eric Pouech <epouech(a)codeweavers.com>

Introduced in 98d209752cee9abd8dc31dfe1f28811066b0b83f.
An application (Idol Showdown) fails to play its intro video without
this change.

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com>
---
 dlls/winegstreamer/media_source.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/winegstreamer/media_source.c b/dlls/winegstreamer/media_source.c
index 63147d64b32..37fcb0478d9 100644
--- a/dlls/winegstreamer/media_source.c
+++ b/dlls/winegstreamer/media_source.c
@@ -930,7 +930,7 @@ static HRESULT media_stream_init_desc(struct media_stream *stream)
 
                 if (FAILED(hr = MFCreateMediaType(&iyuv_type)))
                     goto done;
-                if (FAILED(hr = IMFMediaType_CopyAllItems(iyuv_type, (IMFAttributes *)iyuv_type)))
+                if (FAILED(hr = IMFMediaType_CopyAllItems(new_type, (IMFAttributes *)iyuv_type)))
                     goto done;
                 if (FAILED(hr = IMFMediaType_SetGUID(iyuv_type, &MF_MT_SUBTYPE, &MFVideoFormat_IYUV)))
                     goto done;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2771

[PATCH v2 0/1] MR2771: winestreamer: Don't set twice the same format in stream description. - approved

[Zebediah Figura (＠zfigura)]

This merge request was approved by Zebediah Figura.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2771

[Zebediah Figura (＠zfigura)]

There's a spelling error in the patch subject, by the way.
> An application (Idol Showdown) fails to play its intro video when the base type format is duplicated.

It'd be nice to add a regression test duplicating what this application does, if possible.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2771#note_32391