Re: [PATCH v3 0/1] MR6425: include: Name parameters in LPPROGRESS_ROUTINE typedef
Alex Henrie (@alexhenrie) commented about include/winbase.h:
* This one seems to be a Win32 only definition. It also is defined with * WINAPI instead of CALLBACK in the windows headers. */ -typedef DWORD (CALLBACK *LPPROGRESS_ROUTINE)(LARGE_INTEGER, LARGE_INTEGER, LARGE_INTEGER, - LARGE_INTEGER, DWORD, DWORD, HANDLE, - HANDLE, LPVOID); +typedef DWORD (CALLBACK *LPPROGRESS_ROUTINE)( + LARGE_INTEGER TotalFileSize, + LARGE_INTEGER TotalBytesTransferred, + LARGE_INTEGER StreamSize, + LARGE_INTEGER StreamBytesTransferred, + DWORD dwStreamNumber, + DWORD dwCallbackReason, + HANDLE hSourceFile, + HANDLE hDestinationFile, + LPVOID lpData If we're going to do this, can we please use `void *` instead of `LPVOID`, name each parameter in snake_case, and not devote an entire line to each parameter?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6425#note_80916
participants (1)
-
Alex Henrie (@alexhenrie)