[PATCH 0/1] MR4524: dmime: Add Release() on some codepath.
Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4524
From: Eric Pouech <epouech(a)codeweavers.com> Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> --- dlls/dmime/segment.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dlls/dmime/segment.c b/dlls/dmime/segment.c index e806a845d37..4708b4c5a6f 100644 --- a/dlls/dmime/segment.c +++ b/dlls/dmime/segment.c @@ -373,7 +373,10 @@ static HRESULT WINAPI segment_GetParam(IDirectMusicSegment8 *iface, REFGUID type for (i = 0, count = 0; i < DMUS_SEG_ANYTRACK && count <= index; i++) { if (FAILED(segment_GetTrack(iface, &GUID_NULL, group, i, &track))) break; if (FAILED(IDirectMusicTrack_IsParamSupported(track, type))) + { + IDirectMusicTrack_Release(track); continue; + } if (index == count || index == DMUS_SEG_ANYTRACK) hr = IDirectMusicTrack_GetParam(track, type, time, next, param); IDirectMusicTrack_Release(track); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/4524
Stumbled into this while debugging some dmime stuff. (Un)fortunately, doesn't fix what I'm debugging. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4524#note_53935
This merge request was approved by Michael Stefaniuc. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4524
Unrelated test failure in input.c -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4524#note_53990
participants (3)
-
Eric Pouech -
eric pouech (@epo) -
Michael Stefaniuc (@mstefani)