[PATCH 0/1] MR9728: wined3d: Properly compare reduction modes in wined3d_texture_gl_apply_sampler_desc().

[Henri Verbeet (＠hverbeet)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9728

[PATCH 1/1] wined3d: Properly compare reduction modes in wined3d_texture_gl_apply_sampler_desc().

[Henri Verbeet]

From: Henri Verbeet <hverbeet(a)locutus.nl>

This was an oversight in commit
40df7cdf392d823c741458d22ec071e27fe35a17. The existing code happens to
work for changes between WEIGHTED_AVERAGE and any of the other reduction
modes, but wouldn't work for e.g. changes between MINIMUM and MAXIMUM.
---
 dlls/wined3d/texture_gl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/wined3d/texture_gl.c b/dlls/wined3d/texture_gl.c
index 97e40d46601..4996a24545c 100644
--- a/dlls/wined3d/texture_gl.c
+++ b/dlls/wined3d/texture_gl.c
@@ -2888,7 +2888,7 @@ void wined3d_texture_gl_apply_sampler_desc(struct wined3d_texture_gl *texture_gl
         gl_tex->sampler_desc.srgb_decode = sampler_desc->srgb_decode;
     }
 
-    if (!sampler_desc->reduction_mode != !gl_tex->sampler_desc.reduction_mode)
+    if (sampler_desc->reduction_mode != gl_tex->sampler_desc.reduction_mode)
     {
         GLenum reduction_mode = wined3d_gl_filter_reduction_mode(sampler_desc->reduction_mode);
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/9728