[PATCH v2 0/1] MR2212: riched20/tests: Add context to the EM_FORMATRANGE tests.

[Francois Gouget (＠fgouget)]

--
  v2: riched20/tests: Add context to the EM_FORMATRANGE tests.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2212

[PATCH v2 1/1] riched20/tests: Add context to the EM_FORMATRANGE tests.

[Francois Gouget]

From: Francois Gouget <fgouget(a)codeweavers.com>

---
 dlls/riched20/tests/editor.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/riched20/tests/editor.c b/dlls/riched20/tests/editor.c
index ab741f23035..8968a966de7 100644
--- a/dlls/riched20/tests/editor.c
+++ b/dlls/riched20/tests/editor.c
@@ -5731,6 +5731,7 @@ static void test_EM_FORMATRANGE(void)
     SIZE stringsize;
     int len;
 
+    winetest_push_context("%d", i);
     SendMessageA(hwndRichEdit, WM_SETTEXT, 0, (LPARAM)fmtstrings[i].string);
 
     gtl.flags = GTL_NUMCHARS | GTL_PRECISE;
@@ -5787,6 +5788,7 @@ static void test_EM_FORMATRANGE(void)
     todo_wine {
     ok(r == len, "Expected %d, got %d\n", len, r);
     }
+    winetest_pop_context();
   }
 
   ReleaseDC(NULL, hdc);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2212

[PATCH v2 1/1] riched20/tests: Add context to the EM_FORMATRANGE tests.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=129454

Your paranoid android.


=== w7u_adm (32 bit report) ===

riched20:
editor.c:6684: Test failed: Window shouldn't be visible.

[Francois Gouget (＠fgouget)]

On Wed Feb 15 17:16:49 2023 +0000, **** wrote:
> Marvin replied on the mailing list:
> ```
> Hi,
> It looks like your patch introduced the new failures shown below.
> Please investigate and fix them before resubmitting your patch.
> If they are not new, fixing them anyway would help a lot. Otherwise
> please ask for the known failures list to be updated.
> The tests also ran into some preexisting test failures. If you know how
> to fix them that would be helpful. See the TestBot job for the details:
> The full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=129451
> Your paranoid android.
> === w10pro64_en_AE_u8 (64 bit report) ===
> riched20:
> editor.c:5783: Test failed: 0:: Expected < 9, got 10
> ```
> This MR changes the format of the failure message which caused the TestBot to report it as new.
> See https://bugs.winehq.org/show_bug.cgi?id=54494

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2212#note_24401

[Francois Gouget (＠fgouget)]

v2: Removed the trailing colon, the winetest context already adds one.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2212#note_24405

[Francois Gouget (＠fgouget)]

On Wed Feb 15 18:48:48 2023 +0000, **** wrote:
> Marvin replied on the mailing list:
> ```
> Hi,
> It looks like your patch introduced the new failures shown below.
> Please investigate and fix them before resubmitting your patch.
> If they are not new, fixing them anyway would help a lot. Otherwise
> please ask for the known failures list to be updated.
> The tests also ran into some preexisting test failures. If you know how
> to fix them that would be helpful. See the TestBot job for the details:
> The full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=129454
> Your paranoid android.
> === w7u_adm (32 bit report) ===
> riched20:
> editor.c:6684: Test failed: Window shouldn't be visible.
> ```
> And this is another (rare but) preexisting failure:
> https://bugs.winehq.org/show_bug.cgi?id=54497

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2212#note_24462

[PATCH v2 0/1] MR2212: riched20/tests: Add context to the EM_FORMATRANGE tests. - approved

[Huw Davies (＠huw)]

This merge request was approved by Huw Davies.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2212