[PATCH 0/1] MR2326: kernelbase: Add DiscardVirtualMemory() stub.

[Brendan Shanks (＠bshanks)]

This is required by the latest versions of Chromium.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2326

[PATCH 1/1] kernelbase: Add DiscardVirtualMemory() stub.

[Brendan Shanks]

From: Brendan Shanks <bshanks(a)codeweavers.com>

---
 dlls/kernel32/kernel32.spec     |  1 +
 dlls/kernelbase/kernelbase.spec |  2 +-
 dlls/kernelbase/memory.c        | 10 ++++++++++
 include/memoryapi.h             |  1 +
 4 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec
index d6b0eb62a69..ea02dd0447b 100644
--- a/dlls/kernel32/kernel32.spec
+++ b/dlls/kernel32/kernel32.spec
@@ -371,6 +371,7 @@
 @ stdcall -import DeleteProcThreadAttributeList(ptr)
 # @ stub DisableThreadProfiling
 @ stdcall DisassociateCurrentThreadFromCallback(ptr) NTDLL.TpDisassociateCallback
+@ stdcall DiscardVirtualMemory(ptr long) kernelbase.DiscardVirtualMemory
 @ stdcall DeleteTimerQueue(long)
 @ stdcall -import DeleteTimerQueueEx(long long)
 @ stdcall -import DeleteTimerQueueTimer(long long long)
diff --git a/dlls/kernelbase/kernelbase.spec b/dlls/kernelbase/kernelbase.spec
index e3a0ad257f2..af3af8ecabe 100644
--- a/dlls/kernelbase/kernelbase.spec
+++ b/dlls/kernelbase/kernelbase.spec
@@ -269,7 +269,7 @@
 @ stdcall DisablePredefinedHandleTableInternal(long)
 @ stdcall DisableThreadLibraryCalls(long)
 @ stdcall DisassociateCurrentThreadFromCallback(ptr) ntdll.TpDisassociateCallback
-# @ stub DiscardVirtualMemory
+@ stdcall DiscardVirtualMemory(ptr long)
 @ stdcall DisconnectNamedPipe(long)
 @ stdcall DnsHostnameToComputerNameExW(wstr ptr ptr)
 # @ stub DsBindWithSpnExW
diff --git a/dlls/kernelbase/memory.c b/dlls/kernelbase/memory.c
index 4bcd4a639f6..9f8265b34ae 100644
--- a/dlls/kernelbase/memory.c
+++ b/dlls/kernelbase/memory.c
@@ -52,6 +52,16 @@ BOOLEAN WINAPI RtlSetUserValueHeap( HANDLE handle, ULONG flags, void *ptr, void
  ***********************************************************************/
 
 
+/***********************************************************************
+ *             DiscardVirtualMemory   (kernelbase.@)
+ */
+DWORD WINAPI DECLSPEC_HOTPATCH DiscardVirtualMemory( void *addr, SIZE_T size )
+{
+    FIXME_(virtual)( "stub: %p %#Ix\n", addr, size );
+    return ERROR_CALL_NOT_IMPLEMENTED;
+}
+
+
 /***********************************************************************
  *             FlushViewOfFile   (kernelbase.@)
  */
diff --git a/include/memoryapi.h b/include/memoryapi.h
index 8743e67927c..6728b832fa7 100644
--- a/include/memoryapi.h
+++ b/include/memoryapi.h
@@ -41,5 +41,6 @@ typedef struct WIN32_MEMORY_REGION_INFORMATION
     SIZE_T CommitSize;
 } WIN32_MEMORY_REGION_INFORMATION;
 
+DWORD WINAPI DiscardVirtualMemory(void *addr, SIZE_T size);
 BOOL WINAPI QueryVirtualMemoryInformation(HANDLE process,const void *addr,
         WIN32_MEMORY_INFORMATION_CLASS info_class, void *info, SIZE_T size, SIZE_T *ret_size);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2326

[PATCH 0/1] MR2326: kernelbase: Add DiscardVirtualMemory() stub. - approved

[Etaash Mathamsetty (＠etaash.mathamsetty)]

This merge request was approved by Etaash Mathamsetty.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2326

[Torge Matthies (＠tmatthies)]

This could be implemented as

```c
return VirtualAlloc( addr, size, MEM_RESET, PAGE_NOACCESS );
```

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2326#note_26157

[Etaash Mathamsetty (＠etaash.mathamsetty)]

On Sat Mar  4 13:24:03 2023 +0000, Torge Matthies wrote:
> This could be implemented as
> ```c
> return VirtualAlloc( addr, size, MEM_RESET, PAGE_NOACCESS );
> ```
> MSDN seems to say that MEM_RESET does the same thing as this function, obv would need tests

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2326#note_26164