[PATCH 0/1] MR2236: gdi32/tests: Mark a couple other D3DKMTCheckOcclusion() tests as flaky.
From: Francois Gouget <fgouget(a)codeweavers.com> They also happen randomly on Windows (see commit 2d19baa6b576). Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=51313 --- See the 2023-02-01 and 02 failures on w1064v1607 and the last 2023-02-06 failure on w864. --- dlls/gdi32/tests/driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/gdi32/tests/driver.c b/dlls/gdi32/tests/driver.c index 9f4835540fc..94f93d61207 100644 --- a/dlls/gdi32/tests/driver.c +++ b/dlls/gdi32/tests/driver.c @@ -799,11 +799,13 @@ static void test_D3DKMTCheckOcclusion(void) occlusion_desc.hWnd = hwnd; status = pD3DKMTCheckOcclusion(&occlusion_desc); + flaky ok(status == STATUS_SUCCESS, "Got unexpected return code %#lx.\n", status); check_owner_desc.hAdapter = open_adapter_gdi_desc.hAdapter; check_owner_desc.VidPnSourceId = open_adapter_gdi_desc.VidPnSourceId; status = pD3DKMTCheckVidPnExclusiveOwnership(&check_owner_desc); + flaky ok(status == STATUS_SUCCESS || status == STATUS_GRAPHICS_PRESENT_UNOCCLUDED, "Got unexpected return code %#lx.\n", status); destroy_device_desc.hDevice = create_device_desc.hDevice; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/2236
This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2236
The D3DKMTCheckOcclusion() tests had some more occlusion failures after the commits from bug 5131: * 2023-02-01 on w1064v1607 (32-bit) * 2023-02-01 on w1064v1607 (64-bit) * 2023-02-06 on w864 (64-bit) along with very many other occlusion failures So this merge request marks them as flaky too. But then we did not get any new failures in the past 10 days. So now I'm not entirely sure this is needed after all: maybe the source of the occlusions got fixed in some other test? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2236#note_24835
participants (3)
-
Francois Gouget -
Francois Gouget (＠fgouget)
-
Huw Davies (＠huw)