[PATCH v3 0/1] MR8214: d3dx9_36: Set shared parameters pointer to NULL when freeing it.

[Yuxuan Shui (＠yshui)]

This pointer might later be passed to _realloc in d3dx_pool_sync_shared_parameter.

--
  v3: d3dx9: Set shared parameters pointer to NULL when freeing it.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8214

[PATCH v3 1/1] d3dx9: Set shared parameters pointer to NULL when freeing it.

[Yuxuan Shui]

From: Yuxuan Shui <yshui(a)codeweavers.com>

This pointer might later be passed to _realloc in d3dx_pool_sync_shared_parameter.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55593
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57230
---
 dlls/d3dx9_36/effect.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c
index 4c655a99736..72e216d3fff 100644
--- a/dlls/d3dx9_36/effect.c
+++ b/dlls/d3dx9_36/effect.c
@@ -1943,6 +1943,7 @@ static void d3dx_pool_release_shared_parameter(struct d3dx_top_level_parameter *
     else
     {
         free(param->shared_data->parameters);
+        param->shared_data->parameters = NULL;
         /* Zeroing table size is required as the entry in pool parameters table can be reused. */
         param->shared_data->size = 0;
         param->shared_data = NULL;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/8214

[Yuxuan Shui (＠yshui)]

On Tue Jun 10 13:45:17 2025 +0000, Matteo Bruni wrote:
> Thanks for the MR! Could you please humor me for a couple of touch ups:
> - Add the two bug references as `Wine-Bug`
> - Use `d3dx9: ` in the patch subject
> done!

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8214#note_106055

[PATCH v3 0/1] MR8214: d3dx9_36: Set shared parameters pointer to NULL when freeing it. - approved

[Matteo Bruni (＠Mystral)]

This merge request was approved by Matteo Bruni.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8214