Re: [PATCH v5 0/3] MR4915: d3d9: Implement Direct3DCreate9On12().

[Jan Sikorski (＠jsikorski)]

Jan Sikorski (@jsikorski) commented about dlls/d3d9/d3d9on12.c:
> +    d3d9on12_ReturnUnderlyingResource,
> +};
> +
> +BOOL d3d9on12_init( struct d3d9on12 **d3d9on12, D3D9ON12_ARGS *override_list, UINT override_entries )
> +{
> +    struct d3d9on12 *object;
> +
> +    if (!override_list || !override_list->Enable9On12 || !override_entries)
> +    {
> +        *d3d9on12 = NULL;
> +        return TRUE;
> +    }
> +
> +    if (!(object = calloc( 1, sizeof(*object) )))
> +        return FALSE;
> +    if (!(object->override_list = calloc( 1, sizeof(D3D9ON12_ARGS) )))
> That's a bit odd: if we only care about the first entry, why not just store it in a static member? Or if we don't care about it, don't store it at all? To me, use of `calloc` here indicates an intention that I'm missing.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4915#note_64355