[PATCH v2 0/1] MR7801: combase: Add a stub for SetRestrictedErrorInfo().

[Nikolay Sivov (＠nsivov)]

Foobar 2000 crashes without it.

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>

--
  v2: combase: Add a stub for SetRestrictedErrorInfo().
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7801

[PATCH v2 1/1] combase: Add a stub for SetRestrictedErrorInfo().

[Nikolay Sivov]

From: Nikolay Sivov <nsivov(a)codeweavers.com>

Foobar 2000 crashes without it.

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>
---
 dlls/combase/combase.spec | 2 +-
 dlls/combase/roapi.c      | 9 +++++++++
 include/roerrorapi.h      | 1 +
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/dlls/combase/combase.spec b/dlls/combase/combase.spec
index 4bdc14334e2..ae13be7e6cc 100644
--- a/dlls/combase/combase.spec
+++ b/dlls/combase/combase.spec
@@ -319,7 +319,7 @@
 @ stub RoUnregisterForApartmentShutdown
 @ stub SetCleanupFlag
 @ stdcall SetErrorInfo(long ptr)
-@ stub SetRestrictedErrorInfo
+@ stdcall SetRestrictedErrorInfo(ptr)
 @ stdcall StringFromCLSID(ptr ptr)
 @ stdcall StringFromGUID2(ptr ptr long)
 @ stdcall StringFromIID(ptr ptr) StringFromCLSID
diff --git a/dlls/combase/roapi.c b/dlls/combase/roapi.c
index 0f8a9438821..8118758d338 100644
--- a/dlls/combase/roapi.c
+++ b/dlls/combase/roapi.c
@@ -480,6 +480,15 @@ HRESULT WINAPI GetRestrictedErrorInfo(IRestrictedErrorInfo **info)
     return E_NOTIMPL;
 }
 
+/***********************************************************************
+ *      SetRestrictedErrorInfo (combase.@)
+ */
+HRESULT WINAPI SetRestrictedErrorInfo(IRestrictedErrorInfo *info)
+{
+    FIXME( "(%p)\n", info );
+    return E_NOTIMPL;
+}
+
 /***********************************************************************
  *      RoOriginateLanguageException (combase.@)
  */
diff --git a/include/roerrorapi.h b/include/roerrorapi.h
index 741347455b1..740b95c2276 100644
--- a/include/roerrorapi.h
+++ b/include/roerrorapi.h
@@ -33,6 +33,7 @@ typedef enum
 } RO_ERROR_REPORTING_FLAGS;
 
 HRESULT WINAPI GetRestrictedErrorInfo(IRestrictedErrorInfo **info);
+HRESULT WINAPI SetRestrictedErrorInfo(IRestrictedErrorInfo *info);
 BOOL    WINAPI RoOriginateError(HRESULT error, HSTRING message);
 BOOL    WINAPI RoOriginateLanguageException(HRESULT error, HSTRING message, IUnknown *language_exception);
 HRESULT WINAPI RoSetErrorReportingFlags(UINT32 flags);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7801

[Nikolay Sivov (＠nsivov)]

On Sat Apr 19 14:52:05 2025 +0000, Huw Davies wrote:
> Could we add the prototype to `roerrorapi.h` please?
> Done.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7801#note_101448

[Huw Davies (＠huw)]

Huw Davies (@huw) commented about include/roerrorapi.h:
> } RO_ERROR_REPORTING_FLAGS;
>
> HRESULT WINAPI GetRestrictedErrorInfo(IRestrictedErrorInfo **info);
> +HRESULT WINAPI SetRestrictedErrorInfo(IRestrictedErrorInfo *info);
>  BOOL    WINAPI RoOriginateError(HRESULT error, HSTRING message);
>  BOOL    WINAPI RoOriginateLanguageException(HRESULT error, HSTRING message, IUnknown *language_exception);
>  HRESULT WINAPI RoSetErrorReportingFlags(UINT32 flags);
> Could we keep these in alphabetical order please?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7801#note_101449