[PATCH 0/1] MR5231: ntdll: Add SDL to the special variable list.

[Aida Jonikienė]

Overriding the SDL_VIDEODRIVER variable (for Wayland support as an example)
on the Linux side can lead to some games under Wine failing to load (so treat
those variables as special).

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5231

[PATCH 1/1] ntdll: Add SDL to the special variable list.

[Aida Jonikienė]

From: Aida Jonikienė <aidas957(a)gmail.com>

Overriding the SDL_VIDEODRIVER variable (for Wayland support as an example)
on the Linux side can lead to some games under Wine failing to load (so treat
those variables as special).
---
 dlls/ntdll/unix/env.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/ntdll/unix/env.c b/dlls/ntdll/unix/env.c
index ad9ab0dc220..29e4c8f82e3 100644
--- a/dlls/ntdll/unix/env.c
+++ b/dlls/ntdll/unix/env.c
@@ -341,7 +341,8 @@ static BOOL is_special_env_var( const char *var )
             STARTS_WITH( var, "TEMP=" ) ||
             STARTS_WITH( var, "TMP=" ) ||
             STARTS_WITH( var, "QT_" ) ||
-            STARTS_WITH( var, "VK_" ));
+            STARTS_WITH( var, "VK_" ) ||
+            STARTS_WITH( var, "SDL_" ));
 }
 
 /* check if an environment variable changes dynamically in every new process */
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5231

[PATCH 1/1] ntdll: Add SDL to the special variable list.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=143702

Your paranoid android.


=== debian11b (64 bit WoW report) ===

user32:
input.c:3864: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 00000000017000D6, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032

[Rémi Bernon]

I don't think we want to drop every SDL variable. They are useful to control winebus SDL backend.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5231#note_63501

[Aida Jonikienė]

On Tue Mar  5 08:37:17 2024 +0000, Rémi Bernon wrote:
> I don't think we want to drop every SDL variable. They are useful to
> control winebus SDL backend.
> So should I only hide SDL_VIDEODRIVER? That's enough to prevent issues in my case

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5231#note_63502