Re: [PATCH v5 0/3] MR5923: winegstreamer: Use affinity to determine 'max-threads' value.
Rémi Bernon (@rbernon) commented about dlls/winegstreamer/unixlib.c:
return STATUS_UNSUCCESSFUL; }
+ if (SUCCEEDED(NtQueryInformationProcess( GetCurrentProcess(), + ProcessAffinityMask, &process_mask, sizeof(process_mask), NULL ))) + thread_count = popcount(process_mask); + else + thread_count = 0;
```suggestion:-4+0 if (!NtQueryInformationProcess(GetCurrentProcess(), ProcessAffinityMask, &process_mask, sizeof(process_mask), NULL))) thread_count = popcount(process_mask); else thread_count = 0; ``` SUCCEEDED is for HRESULT, Nt API returns NTSTATUS and we often just check that it's 0. Also note the style fixes (no space in paren here, continuation indent is 8 spaces). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5923#note_74517
participants (1)
-
Rémi Bernon