[PATCH 0/1] MR2129: loader: In macOS preloader, fix an environment variable sometimes being lost.

[Brendan Shanks (＠bshanks)]

On Ventura (and likely also on Monterey), `dyld`/`libc` seems to store the `environ` pointer from when the preloader launches, ignores any change to `environ` done in the preloader, and then uses that original `environ` in the launched wine process.

The preloader has to move the start of the environment down by one, and this was causing the first variable to be lost on Monterey/Ventura. Instead of moving the entire environment, add a dummy variable at the beginning so nothing important is lost.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2129

[PATCH 1/1] loader: In macOS preloader, fix an environment variable sometimes being lost.

[Brendan Shanks]

From: Brendan Shanks <bshanks(a)codeweavers.com>

---
 loader/preloader_mac.c | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/loader/preloader_mac.c b/loader/preloader_mac.c
index 5df185d0960..ce7a14e17ae 100644
--- a/loader/preloader_mac.c
+++ b/loader/preloader_mac.c
@@ -619,25 +619,22 @@ static inline void get_dyld_func( const char *name, void **func )
 static void fixup_stack( void *stack )
 {
     int *pargc;
-    char **argv, **env, **apple, **apple_end;
+    char **argv, **env_new;
+    static char dummyvar[] = "WINEPRELOADERDUMMYVAR=1";
 
     pargc = stack;
     argv = (char **)pargc + 1;
-    env = &argv[*pargc-1] + 2;
-
-    apple = env;
-    while (*apple)
-        apple++;
-    apple++;
-
-    apple_end = apple;
-    while (*apple_end)
-        apple_end++;
-    apple_end++;
 
-    /* decrement argc, and move all the data between &argv[1] and apple_end down to start at &argv[0] */
+    /* decrement argc, and "remove" argv[0] */
     *pargc = *pargc - 1;
-    memmove(&argv[0], &argv[1], (char *)apple_end - (char *)&argv[1]);
+    memmove( &argv[0], &argv[1], (*pargc + 1) * sizeof(char *) );
+
+    env_new = &argv[*pargc-1] + 2;
+    /* In the launched binary on some OSes, _NSGetEnviron() returns
+     * the original 'environ' pointer, so env_new[0] would be ignored.
+     * Put a dummy variable in env_new[0], so nothing is lost in this case.
+     */
+    env_new[0] = dummyvar;
 }
 
 static void set_program_vars( void *stack, void *mod )
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2129