[PATCH 0/1] MR3091: include: Avoid redefinitions of __fastcall on FreeBSD

[Gerald Pfeifer (＠gerald)]

After commit b337c5b1a1757b2abbc90a7c6955d64242861ab9 builds on FreeBSD
see 115 instances of

  include/windef.h:60: warning: "__fastcall" redefined

which comes from <stdio.h> including <sys/cdefs.h> which in turns has

  #define __fastcall      __attribute__((__fastcall__))

Simply #undef-ining __fastcall like we do for some other cases already
addresses this.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3091

[PATCH 1/1] include: Avoid redefinitions of __fastcall on FreeBSD

[Gerald Pfeifer]

From: Gerald Pfeifer <gerald(a)pfeifer.com>

After commit b337c5b1a1757b2abbc90a7c6955d64242861ab9 builds on FreeBSD
see 115 instances of

  include/windef.h:60: warning: "__fastcall" redefined

which comes from <stdio.h> including <sys/cdefs.h> which in turns has

  #define __fastcall      __attribute__((__fastcall__))

Simply #undef-ining __fastcall like we do for some other cases already
addresses this.
---
 include/windef.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/windef.h b/include/windef.h
index b5f8f3d0b4c..86171ce2333 100644
--- a/include/windef.h
+++ b/include/windef.h
@@ -59,6 +59,7 @@ extern "C" {
 #ifdef WINE_UNIX_LIB
 # define __stdcall
 # define __cdecl
+# undef  __fastcall
 # define __fastcall
 #else
 # undef __stdcall
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3091

[PATCH 1/1] include: Avoid redefinitions of __fastcall on FreeBSD

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=133877

Your paranoid android.


=== debian11 (32 bit report) ===

Report validation errors:
quartz:vmr7 has no test summary line (early exit of the main process?)
quartz:vmr7 has unaccounted for todo messages
quartz:vmr7 has unaccounted for skip messages

[PATCH 0/1] MR3091: include: Avoid redefinitions of __fastcall on FreeBSD - closed

[Alexandre Julliard (＠julliard)]

This merge request was closed by Alexandre Julliard.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3091

[Alexandre Julliard (＠julliard)]

Superseded by 718068c42ca1f70ac8f94027f898354b5d4c94e7.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3091#note_36376