[PATCH v2 0/1] MR2898: winegstreamer: Forbid vaapidecodebin when looking for a specific element.

[Rémi Bernon]

This will eventually fallback to vaapih264dec and similar decoders if
VA-API plugins are indeed available.

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/2893, as this doesn't have any effect unless VA-API plugins are installed, and they aren't on the testbot or Gitlab.

--
  v2: winegstreamer: Forbid vaapidecodebin when looking for a specific element.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2898

[PATCH v2 1/1] winegstreamer: Forbid vaapidecodebin when looking for a specific element.

[Rémi Bernon]

From: Rémi Bernon <rbernon(a)codeweavers.com>

This will eventually fallback to vaapih264dec and similar decoders if
VA-API plugins are indeed available.
---
 dlls/winegstreamer/unixlib.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/dlls/winegstreamer/unixlib.c b/dlls/winegstreamer/unixlib.c
index 6ffd41e9712..6ed38260536 100644
--- a/dlls/winegstreamer/unixlib.c
+++ b/dlls/winegstreamer/unixlib.c
@@ -101,6 +101,16 @@ GstElement *find_element(GstElementFactoryListType type, GstCaps *src_caps, GstC
     for (tmp = transforms; tmp != NULL && element == NULL; tmp = tmp->next)
     {
         name = gst_plugin_feature_get_name(GST_PLUGIN_FEATURE(tmp->data));
+
+        if (!strcmp(name, "vaapidecodebin"))
+        {
+            /* vaapidecodebin adds asynchronicity which breaks wg_transform synchronous drain / flush
+             * requirements. Ignore it and use VA-API decoders directly instead.
+             */
+            GST_WARNING("Ignoring vaapidecodebin decoder.");
+            continue;
+        }
+
         if (!(element = gst_element_factory_create(GST_ELEMENT_FACTORY(tmp->data), NULL)))
             GST_WARNING("Failed to create %s element.", name);
     }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2898

[PATCH v2 0/1] MR2898: winegstreamer: Forbid vaapidecodebin when looking for a specific element. - approved

[Zebediah Figura (＠zfigura)]

This merge request was approved by Zebediah Figura.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2898