Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
Zebediah Figura (@zfigura) commented about dlls/ws2_32/tests/sock.c:
+ + client = socket(AF_UNIX, SOCK_STREAM, 0); + ok(client != INVALID_SOCKET, "Failed to create second Unix socket: %lu\n", + GetLastError()); + + clientThread = CreateThread(NULL, 0, test_afunix_client_connect_thread, + &(struct afunix_thread_param){ client, addr }, 0, NULL); + ok(clientThread != NULL, "CreateThread failed unexpectedly: %ld\n", GetLastError()); + server = accept(listener, NULL, NULL); + ok(server != INVALID_SOCKET, "Could not accept Unix socket connection: %lu\n", + GetLastError()); + + WaitForSingleObject(clientThread, 1000); + + memset(&outAddr, 0, sizeof(outAddr)); + ret = getsockname(listener, (SOCKADDR *)&outAddr, &(int){sizeof(outAddr)}); Here and elsewhere, we should actually test the returned length.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35926
participants (1)
-
Zebediah Figura (@zfigura)