[PATCH 0/1] MR7903: krnl386: Fix comments for DPMI 0202h/0203h calls (Processor Exception Handler Vector)
DPMI functions 0202h and 0203h related to Processor Exception Handler Vector are not supported by wine. So update FIXME comments about this fact. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7903
From: Pali Rohár <pali(a)kernel.org> DPMI functions 0202h and 0203h related to Processor Exception Handler Vector are not supported by wine. So update FIXME comments about this fact. Signed-off-by: Pali Rohár <pali(a)kernel.org> --- dlls/krnl386.exe16/int31.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/krnl386.exe16/int31.c b/dlls/krnl386.exe16/int31.c index 0d13763451c..94f6a29a863 100644 --- a/dlls/krnl386.exe16/int31.c +++ b/dlls/krnl386.exe16/int31.c @@ -394,14 +394,14 @@ void WINAPI DOSVM_Int31Handler( CONTEXT *context ) break; case 0x0202: /* Get Processor Exception Handler Vector */ - FIXME( "Get Processor Exception Handler Vector (0x%02x)\n", + FIXME( "Get Processor Exception Handler Vector (0x%02x) - not supported\n", BL_reg(context) ); SET_CX( context, 0 ); SET_DX( context, 0 ); break; case 0x0203: /* Set Processor Exception Handler Vector */ - FIXME( "Set Processor Exception Handler Vector (0x%02x)\n", + FIXME( "Set Processor Exception Handler Vector (0x%02x) - not supported\n", BL_reg(context) ); break; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/7903
This merge request was closed by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7903
That doesn't seem necessary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7903#note_113243
On Sat Aug 30 08:14:27 2025 +0000, Alexandre Julliard wrote:
That doesn't seem necessary. For debugging purposes it is necessary to know that something was called which is not implemented. This is just a simple change which improves the debugging ability, so I slightly do not understand your argument...
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7903#note_114270
On Sat Aug 30 08:14:27 2025 +0000, Pali Rohár wrote:
For debugging purposes it is necessary to know that something was called which is not implemented. This is just a simple change which improves the debugging ability, so I slightly do not understand your argument... If some app calls this, we'll see a FIXME in the log, and someone will need to investigate it. Adding "not supported" to the message doesn't make any difference.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7903#note_114291
participants (2)
-
Alexandre Julliard (@julliard) -
Pali Rohár