Re: [PATCH v5 0/5] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux

[Huw Davies (＠huw)]

On Mon Aug  8 14:11:55 2022 +0000, Francois Gouget wrote:
> Ah, right.
> Well, there is a `memset( &ip_h, 0, sizeof(ip_h) );` earlier on.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_5818

[PATCH v5 0/5] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux

[Paul Gofman]

On 8/8/22 09:14, Huw Davies (@huw) wrote:
> On Mon Aug  8 14:11:55 2022 +0000, Francois Gouget wrote:
> > Ah, right.
> > Well, there is a `memset( &ip_h, 0, sizeof(ip_h) );` earlier on.

Yeah, indeed. Sorry, I messed this up with icmp_h checksum, icmp_h is 
apparently not memset. Yes, this one on ip header is redundant. I will 
send a follow up patch to remove it, but probably after 
https://gitlab.winehq.org/wine/wine/-/merge_requests/602 is finalized.