[PATCH v2 0/1] MR7153: msvcrt: fixed missing TRACE_ON check

[Herman Semenov (＠GermanAizek)]

Is this a mistake? are the brackets very strangely located, or was the condition accidentally deleted there? Maybe legacy code.

--
  v2: msvcrt: fixed missing TRACE_ON check
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7153

[PATCH v2 1/1] msvcrt: fixed missing TRACE_ON check

[Herman Semenov]

From: Herman Semenov <GermanAizek(a)yandex.ru>

Author: Piotr Caban
---
 dlls/msvcrt/undname.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/msvcrt/undname.c b/dlls/msvcrt/undname.c
index 923ec67d363..054bb6b7426 100644
--- a/dlls/msvcrt/undname.c
+++ b/dlls/msvcrt/undname.c
@@ -198,6 +198,7 @@ static BOOL str_array_push(struct parsed_symbol* sym, const char* ptr, int len,
     memcpy(a->elts[a->num], ptr, len);
     a->elts[a->num][len] = '\0'; 
     if (++a->num >= a->max) a->max = a->num;
+    if (TRACE_ON(msvcrt))
     {
         int i;
         char c;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7153

[PATCH v2 1/1] msvcrt: fixed missing TRACE_ON check

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=150937

Your paranoid android.


=== debian11b (64 bit WoW report) ===

user32:
input.c:4305: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 0000000004F100F6, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032

[Herman Semenov (＠GermanAizek)]

On Sun Jan 19 13:13:23 2025 +0000, **** wrote:
> changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/7153/diffs?diff_id=153014&start_sha=1a5a566e08c5268ab4f6a948a3f0f8486bc6662c#99038c8fa9f97419a4a0a8393f578d3c080a79d0_202_203)
> Fixed https://gitlab.winehq.org/wine/wine/-/merge_requests/7153/diffs?commit_id=5f...

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7153#note_92183

[PATCH v2 0/1] MR7153: msvcrt: fixed missing TRACE_ON check - approved

[Piotr Caban (＠piotr)]

This merge request was approved by Piotr Caban.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7153