Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
22 Jan
2023
22 Jan
'23
10:27 p.m.
On Sun Dec 18 23:32:22 2022 +0000, Zebediah Figura wrote:
Can we use a helper function to fix up the scheme instead of using a goto? This will probably also help make the function easier to follow, by virtue of being less monolithic. Sure, that it can be done. Other parts of the code use goto too. I also used already goto in kernel and drivers. ATM i am not able to think about a function which would make it easier. If i use early return from function, i think it makes no difference, but i plan to use a helper function to keep UrlFixup shorter. Any suggestion about the structure is well come, because i think i am blind to other and better ways.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_21341
1062
Age (days ago)
1062
Last active (days ago)
0 comments
1 participants
participants (1)
-
Thomas Csovcsity (@thc13)