[PATCH 0/1] MR4889: winex11: Call XInstallColormap in unmanaged mode.

[Alex Henrie (＠alexhenrie)]

With this change, unchecking "Allow the window manager to control the
windows" in winecfg makes 256-color games look right in Xephyr without
having to run a window manager in Xephyr too.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4889

[PATCH 1/1] winex11: Call XInstallColormap in unmanaged mode.

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

With this change, unchecking "Allow the window manager to control the
windows" in winecfg makes 256-color games look right in Xephyr without
having to run a window manager in Xephyr too.
---
 dlls/winex11.drv/palette.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/dlls/winex11.drv/palette.c b/dlls/winex11.drv/palette.c
index 43974fe8896..1e7cd2e19fd 100644
--- a/dlls/winex11.drv/palette.c
+++ b/dlls/winex11.drv/palette.c
@@ -1291,6 +1291,12 @@ UINT X11DRV_RealizePalette( PHYSDEV dev, HPALETTE hpal, BOOL primary )
 
     }
     pthread_mutex_unlock( &palette_mutex );
+
+    /* if not allowing the window manager to control the windows, don't rely on the window manager
+     * to install the colormap */
+    if (!managed_mode)
+        XInstallColormap( gdi_display, default_colormap );
+
     return iRemapped;
 }
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4889

[PATCH 0/1] MR4889: winex11: Call XInstallColormap in unmanaged mode. - closed

[Alexandre Julliard (＠julliard)]

This merge request was closed by Alexandre Julliard.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4889

[Alexandre Julliard (＠julliard)]

This is not correct per ICCCM. Using unmanaged mode doesn't mean that no window manager is running.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4889#note_58313