[PATCH 0/1] MR9892: winecfg: Remove unnecessary calls to strdupU2W.

[Alex Henrie (＠alexhenrie)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9892

[PATCH 1/1] winecfg: Remove unnecessary calls to strdupU2W.

[Alex Henrie]

From: Alex Henrie <[e-mail]>

---
 programs/winecfg/driveui.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/programs/winecfg/driveui.c b/programs/winecfg/driveui.c
index 611c467b082..6616234d628 100644
--- a/programs/winecfg/driveui.c
+++ b/programs/winecfg/driveui.c
@@ -208,7 +208,7 @@ static int fill_drives_list(HWND dialog)
     {
         LVITEMW item;
         WCHAR *path;
-        char letter[4];
+        WCHAR letter[4];
 
         /* skip over any unused drives */
         if (!drives[i].in_use)
@@ -224,12 +224,11 @@ static int fill_drives_list(HWND dialog)
         item.mask = LVIF_TEXT | LVIF_PARAM;
         item.iItem = count;
         item.iSubItem = 0;
-        item.pszText = strdupU2W(letter);
+        item.pszText = letter;
         item.cchTextMax = lstrlenW(item.pszText);
         item.lParam = (LPARAM) &drives[i];
 
         lv_insert_item(dialog, &item);
-        free(item.pszText);
 
         path = strdupU2W(drives[i].unixpath);
         lv_set_item_text(dialog, count, 1, path);
@@ -513,7 +512,7 @@ static void on_edit_changed(HWND dialog, WORD id)
             else
             {
                 path = NULL;
-                wpath = strdupU2W("drive_c");
+                wpath = wcsdup(L"drive_c");
             }
 
             free(current_drive->unixpath);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/9892